[coreboot-gerrit] Change in coreboot[master]: commonlib/region: Allow multiple windows for xlate_region_dev

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47658 )

Change subject: commonlib/region: Allow multiple windows for xlate_region_dev
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47658/12/src/soc/intel/apollolake/m... 
File src/soc/intel/apollolake/mmap_boot.c:

https://review.coreboot.org/c/coreboot/+/47658/12/src/soc/intel/apollolake/m... 
PS12, Line 85: map = rdev_mmap(&real_dev.rdev, region_offset(&cbfs_region), region_sz(&cbfs_region));
             : 	if (map)
             : 		rdev_munmap(&real_dev.rdev, map);
> region_overlap() would be true if only part of it were overlapping so maybe not enough? whereas mmap […]

oops should have refreshed, furquan has the same idea.

The mmap call seems ok since it is doing all the checks, but maybe a comment that that is what it is being used for..