Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43156 )
Change subject: sb/intel: Factor out ICH ACPI for HDA ......................................................................
sb/intel: Factor out ICH ACPI for HDA
Files are identical between all three southbridges, and differ for PCH.
Change-Id: Ic6a926af675bda3db3a5795df9e8f490caf3ebf4 Signed-off-by: Angel Pons th3fanbus@gmail.com --- R src/southbridge/intel/common/acpi/audio_ich.asl M src/southbridge/intel/i82801gx/acpi/ich7.asl D src/southbridge/intel/i82801ix/acpi/audio.asl M src/southbridge/intel/i82801ix/acpi/ich9.asl D src/southbridge/intel/i82801jx/acpi/audio.asl M src/southbridge/intel/i82801jx/acpi/ich10.asl 6 files changed, 3 insertions(+), 35 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/43156/1
diff --git a/src/southbridge/intel/i82801gx/acpi/audio.asl b/src/southbridge/intel/common/acpi/audio_ich.asl similarity index 100% rename from src/southbridge/intel/i82801gx/acpi/audio.asl rename to src/southbridge/intel/common/acpi/audio_ich.asl diff --git a/src/southbridge/intel/i82801gx/acpi/ich7.asl b/src/southbridge/intel/i82801gx/acpi/ich7.asl index 08af0a9..4d07720 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7.asl @@ -148,7 +148,7 @@ }
// 0:1b.0 High Definition Audio (Azalia) -#include "audio.asl" +#include <southbridge/intel/common/acpi/audio_ich.asl>
// PCI Express Ports #include <southbridge/intel/common/acpi/pcie.asl> diff --git a/src/southbridge/intel/i82801ix/acpi/audio.asl b/src/southbridge/intel/i82801ix/acpi/audio.asl deleted file mode 100644 index b9c256c..0000000 --- a/src/southbridge/intel/i82801ix/acpi/audio.asl +++ /dev/null @@ -1,16 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Intel ICH HDA */ - -// Intel High Definition Audio (Azalia) 0:1b.0 - -Device (HDEF) -{ - Name (_ADR, 0x001b0000) - - // Power Resources for Wake - Name (_PRW, Package(){ - 5, // Bit 5 of GPE - 4 // Can wake from S4 state. - }) -} diff --git a/src/southbridge/intel/i82801ix/acpi/ich9.asl b/src/southbridge/intel/i82801ix/acpi/ich9.asl index 115c254..25a756e 100644 --- a/src/southbridge/intel/i82801ix/acpi/ich9.asl +++ b/src/southbridge/intel/i82801ix/acpi/ich9.asl @@ -151,7 +151,7 @@ }
// 0:1b.0 High Definition Audio (Azalia) -#include "audio.asl" +#include <southbridge/intel/common/acpi/audio_ich.asl>
// PCI Express Ports #include <southbridge/intel/common/acpi/pcie.asl> diff --git a/src/southbridge/intel/i82801jx/acpi/audio.asl b/src/southbridge/intel/i82801jx/acpi/audio.asl deleted file mode 100644 index b9c256c..0000000 --- a/src/southbridge/intel/i82801jx/acpi/audio.asl +++ /dev/null @@ -1,16 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Intel ICH HDA */ - -// Intel High Definition Audio (Azalia) 0:1b.0 - -Device (HDEF) -{ - Name (_ADR, 0x001b0000) - - // Power Resources for Wake - Name (_PRW, Package(){ - 5, // Bit 5 of GPE - 4 // Can wake from S4 state. - }) -} diff --git a/src/southbridge/intel/i82801jx/acpi/ich10.asl b/src/southbridge/intel/i82801jx/acpi/ich10.asl index a79b8a3..e62f8a1 100644 --- a/src/southbridge/intel/i82801jx/acpi/ich10.asl +++ b/src/southbridge/intel/i82801jx/acpi/ich10.asl @@ -152,7 +152,7 @@ }
// 0:1b.0 High Definition Audio (Azalia) -#include "audio.asl" +#include <southbridge/intel/common/acpi/audio_ich.asl>
// PCI Express Ports #include <southbridge/intel/common/acpi/pcie.asl>