Marx Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML ......................................................................
Patch Set 6:
(9 comments)
https://review.coreboot.org/c/coreboot/+/38741/5/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/38741/5/src/soc/intel/cannonlake/in... PS5, Line 58: * this is set to 0 */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/38741/5/src/soc/intel/cannonlake/in... PS5, Line 59: uint8_t tdc_disable;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/38741/5/src/soc/intel/cannonlake/in... PS5, Line 59: uint8_t tdc_disable;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/38741/5/src/soc/intel/cannonlake/vr... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/5/src/soc/intel/cannonlake/vr... PS5, Line 472: tdc[VR_IA_CORE] = (cfg->cpu_pl2_4_cfg == baseline) ? VR_CFG_TDC_AMP(117) : VR_CFG_TDC_AMP(146);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38741/5/src/soc/intel/cannonlake/vr... PS5, Line 474: tdc[VR_IA_CORE] = (cfg->cpu_pl2_4_cfg == baseline) ? VR_CFG_TDC_AMP(86) : VR_CFG_TDC_AMP(125);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38741/5/src/soc/intel/cannonlake/vr... PS5, Line 502: printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config and apply Auto/default settings\n", mch_id);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38741/6/src/soc/intel/cannonlake/vr... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/6/src/soc/intel/cannonlake/vr... PS6, Line 472: tdc[VR_IA_CORE] = (cfg->cpu_pl2_4_cfg == baseline) ? VR_CFG_TDC_AMP(117) : VR_CFG_TDC_AMP(146);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38741/6/src/soc/intel/cannonlake/vr... PS6, Line 474: tdc[VR_IA_CORE] = (cfg->cpu_pl2_4_cfg == baseline) ? VR_CFG_TDC_AMP(86) : VR_CFG_TDC_AMP(125);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38741/6/src/soc/intel/cannonlake/vr... PS6, Line 502: printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config and apply Auto/default settings\n", mch_id);
line over 96 characters
Done