Max Blau has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32235 )
Change subject: mainboard: Add MSI MS-7707 ......................................................................
Patch Set 4: Code-Review-1
(3 comments)
Need help here. How can i enable conf-mode (pnp_enter_conf_mode_8787) before devicetree.cb gets applied?
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/devicet... File src/mainboard/medion/ms_7707/devicetree.cb:
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/devicet... PS4, Line 69: register "gpio2_output_enable" = "0x20" # 0xF1 This doesn't work. Any ideas how to set GPIOs?
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/devicet... PS4, Line 76: register "led_vsb_mode_select" = "0x09" # 0xF9 This works but using "register" here is way too complicated. I would rather use 'irq 0xf9 = 0x09' below. But it doesn't work because the whole devicetree.cb stuff lacks 'pnp_enter_conf_mode_8787' to get the SuperIO into conf-mode. Any ideas how to solve this?
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/devicet... PS4, Line 80: io 0x60 = 0x295 HWM doesn't work. Superiotool finds several other bogus chips instead. I will try to compare dmesg logs to see if its maybe a different IO (even though Superiotool.log and datasheet say 0x295 clearly).