build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39663 )
Change subject: soc/intel/braswell: Clean up ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39663/3/src/soc/intel/braswell/chip... File src/soc/intel/braswell/chip.c:
https://review.coreboot.org/c/coreboot/+/39663/3/src/soc/intel/braswell/chip... PS3, Line 91: printk(BIOS_ERR, "Error! Device (%s) not found, soc_silicon_init_params!\n", Prefer using '"%s...", __func__' to using 'soc_silicon_init_params', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/39663/3/src/soc/intel/braswell/lpss... File src/soc/intel/braswell/lpss.c:
https://review.coreboot.org/c/coreboot/+/39663/3/src/soc/intel/braswell/lpss... PS3, Line 111: #define CASE_I2C(name_) case PCI_DEVFN(name_ ## _DEV, name_ ## _FUNC) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39663/3/src/soc/intel/braswell/roms... File src/soc/intel/braswell/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/39663/3/src/soc/intel/braswell/roms... PS3, Line 122: "Error! Device (PCI:0:%02x.%01x) not found, soc_memory_init_params!\n", Prefer using '"%s...", __func__' to using 'soc_memory_init_params', this function's name, in a string