Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42064 )
Change subject: soc/amd/picasso: Allow modification of i2c base addresses in PSP ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86... File src/soc/amd/picasso/i2c-x86.c:
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86... PS5, Line 19: _Static_assert( : ARRAY_SIZE(i2c_bus_address) == I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT, : "ARRAY_SIZE(i2c_bus_address) must equal I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT");
fixing in follow-on patch
Done
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c@... PS12, Line 4: #include <acpi/acpi.h>
unrelated
Done
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c@... PS12, Line 11: #include <soc/iomap.h>
needed
Done
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c@... PS12, Line 12: #include <soc/pci_devs.h>
unrelated […]
Done
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c@... PS12, Line 51: case APU_I2C2_BASE:
from <soc/iomap. […]
Done