13 Jun
2019
13 Jun
'19
11:43 p.m.
Yuji Sasaki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33431 )
Change subject: TEMP: NOT FOR REVIEW: google/mistral: Add LED calibration ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33431/3/src/mainboard/google/mistral/led_cal... File src/mainboard/google/mistral/led_calibration.c:
https://review.coreboot.org/#/c/33431/3/src/mainboard/google/mistral/led_cal... PS3, Line 53: _strspn
please move the string manipulation functions to src/lib/string. […]
Renamed and moved them. atoi is changed to atol to have more commodification between Depthcharge source.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33431
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff3ab55cdd12a8e8fe7549bce99a88ed0ef01534
Gerrit-Change-Number: 33431
Gerrit-PatchSet: 4
Gerrit-Owner: Yuji Sasaki sasakiy@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org
Gerrit-Reviewer: Zhihong Yu zhihongyu@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 13 Jun 2019 21:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment