Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32757
Change subject: soc/intel/broadwell/romstage: Clean up unused bist variable ......................................................................
soc/intel/broadwell/romstage: Clean up unused bist variable
Checking BIST is done in the bootblock.
Change-Id: I3ea2eb6a37c038f7348f0abd2056eee5c07bdb9d Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/broadwell/include/soc/romstage.h M src/soc/intel/broadwell/romstage/romstage.c 2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/32757/1
diff --git a/src/soc/intel/broadwell/include/soc/romstage.h b/src/soc/intel/broadwell/include/soc/romstage.h index 31184f9..86a2c84 100644 --- a/src/soc/intel/broadwell/include/soc/romstage.h +++ b/src/soc/intel/broadwell/include/soc/romstage.h @@ -22,7 +22,6 @@ struct chipset_power_state; struct pei_data; struct romstage_params { - unsigned long bist; struct chipset_power_state *power_state; struct pei_data *pei_data; }; diff --git a/src/soc/intel/broadwell/romstage/romstage.c b/src/soc/intel/broadwell/romstage/romstage.c index d83ff29..0151023 100644 --- a/src/soc/intel/broadwell/romstage/romstage.c +++ b/src/soc/intel/broadwell/romstage/romstage.c @@ -65,10 +65,7 @@ /* Entry from assembly_entry.S. */ asmlinkage void car_stage_entry(void) { - struct romstage_params rp = { - .bist = 0, /* checking done in the bootblock */ - .pei_data = NULL, - }; + struct romstage_params rp;
post_code(0x30);