Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38539 ) Change subject: ec/google/chromeec: Add new host command, EC_CMD_GET_PD_PORT_CAPS ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/38539/4/src/ec/google/chromeec/ec_c... File src/ec/google/chromeec/ec_commands.h: https://review.coreboot.org/c/coreboot/+/38539/4/src/ec/google/chromeec/ec_c... PS4, Line 5894: Various positions on the device. The first word describes the side of the device I understand that you have changed this to make it more aligned with coreboot coding style, but this file is generally copied over from EC codebase as is. And even if you make the change here today, in the future any time the file is copied over again, this will get overwritten and show as a diff. As Duncan mentioned on an earlier patchset, this header is used in multiple codebases and so it would be good to maintain consistency with the EC source. -- To view, visit https://review.coreboot.org/c/coreboot/+/38539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I923e4b637a2f41ce173d378ba5030f1ae8c22222 Gerrit-Change-Number: 38539 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie@chromium.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 29 Jan 2020 07:37:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment