View Change

1 comment:

• File src/ec/google/chromeec/ec_commands.h:

  • Patch Set #4, Line 5894: Various positions on the device. The first word describes the side of the device

    I understand that you have changed this to make it more aligned with coreboot coding style, but this file is generally copied over from EC codebase as is. And even if you make the change here today, in the future any time the file is copied over again, this will get overwritten and show as a diff. As Duncan mentioned on an earlier patchset, this header is used in multiple codebases and so it would be good to maintain consistency with the EC source.

To view, visit change 38539. To unsubscribe, or for help writing mail filters, visit settings.