Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34195 )
Change subject: drivers/elog: Fix ELOG_GSMI dependency ......................................................................
drivers/elog: Fix ELOG_GSMI dependency
SMM_TSEG is a qualifier between TSEG and ASEG only, while HAVE_SMI_HANDLER currently tells if SMM will be installed.
Move rest of the file under same 'if ELOG' block.
Change-Id: I620d3ce5aa9632d862d6480922144f002cf6423b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34195 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/elog/Kconfig 1 file changed, 4 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/drivers/elog/Kconfig b/src/drivers/elog/Kconfig index da8a5fa..4a66e78 100644 --- a/src/drivers/elog/Kconfig +++ b/src/drivers/elog/Kconfig @@ -42,10 +42,8 @@ help This option will enable event logging from the preram stage.
-endif - config ELOG_GSMI - depends on ELOG && SMM_TSEG + depends on HAVE_SMI_HANDLER bool "SMI interface to write and clear event log" select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP default n @@ -55,7 +53,6 @@ kernel reset/shutdown messages to the event log.
config ELOG_BOOT_COUNT - depends on ELOG bool "Maintain a monotonic boot number in CMOS" default n help @@ -64,9 +61,11 @@ counter will be logged as part of the System Boot event.
config ELOG_BOOT_COUNT_CMOS_OFFSET - depends on ELOG && ELOG_BOOT_COUNT && !USE_OPTION_TABLE + depends on ELOG_BOOT_COUNT && !USE_OPTION_TABLE int "Offset in CMOS to store the boot count" default 0 help This value must be greater than 16 bytes so as not to interfere with the standard RTC region. Requires 8 bytes. + +endif