Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37787 )
Change subject: security/vboot: Add a dedicated flag for building of vboot library ......................................................................
Patch Set 7:
(3 comments)
Another naming option would be to use:
VBOOT (or VBOOT_LIB) - include the vboot library functions VBOOT_VERIFY_FIRMWARE - enable firmware verification
What do you think?
I would rather keep the VBOOT flag, for I don't know how to efficiently and correctly change hundreds of its appearance around the whole coreboot tree.
Check out the `sed` utility.
https://review.coreboot.org/c/coreboot/+/37787/4/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/37787/4/src/security/vboot/Kconfig@... PS4, Line 19: bool
"help" description added, but VBOOT_LIB is designed as a hidden flag for other visible flags (e.g. […]
Okay, that makes sense.
https://review.coreboot.org/c/coreboot/+/37787/7/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/37787/7/src/security/vboot/Kconfig@... PS7, Line 22: Building and linking the vboot library. How about just "Build and link the vboot library. Makes the vboot API accessible across all coreboot stages, without enabling vboot verification. For verification, please see the VBOOT option below."
https://review.coreboot.org/c/coreboot/+/37787/4/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37787/4/src/security/vboot/Makefile... PS4, Line 137: $(eval $(call vboot-for-stage,verstage))
I believe verstage is introduced for verified boot. […]
OK.