Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29970 )
Change subject: Mistral: QCS405: Added RPM support
......................................................................
Patch Set 14: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/29970/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29970/14//COMMIT_MSG@7
PS14, Line 7: Mistral:
while this is for the mistral project, the change itself only touches qcs405, so drop this.
https://review.coreboot.org/#/c/29970/14/src/soc/qualcomm/qcs405/rpm_load_re...
File src/soc/qualcomm/qcs405/rpm_load_reset.c:
https://review.coreboot.org/#/c/29970/14/src/soc/qualcomm/qcs405/rpm_load_re...
PS14, Line 46: NIT:
what's NIT: supposed to mean here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29970
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17f491f0a4bd0dce7522b7e80e1bac97ec18b945
Gerrit-Change-Number: 29970
Gerrit-PatchSet: 14
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 06 Mar 2019 11:31:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
