Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar
......................................................................
Patch Set 4: Code-Review+1
(4 comments)
LGTM, save for some nits in the commit message
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@7
PS4, Line 7: crad
typo: card
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@7
PS4, Line 7: for lindar
I would drop this part (already specified in the prefix)
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@9
PS4, Line 9: in GPIO early table.
please wrap commit messages at 72 characters
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@9
PS4, Line 9: (GPP_D16)
nit: no parentheses here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f
Gerrit-Change-Number: 47799
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Allen Cheng
allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Leo3 Chen
leo3.chen@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Thu, 26 Nov 2020 09:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment