Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55205 )
Change subject: mb/intel/adlrvp: Use device aliases ......................................................................
Patch Set 3:
(7 comments)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/b04a1065_0222a53c PS2, Line 320: device pci 10.0 off end : device pci 10.1 off end : device pci 10.6 off end # THC0 : device pci 10.7 off end # THC1
Hmmm, I see. It's somewhat annoying (why couldn't ADL-P and ADL-S use the same PCI B:D. […]
true
https://review.coreboot.org/c/coreboot/+/55205/comment/9628e877_c4e5afb6 PS2, Line 324: device pci 11.0 off end : device pci 11.1 off end : device pci 11.2 off end : device pci 11.3 off end : device pci 11.4 off end : device pci 11.5 off end
Alright, I see. I'd appreciate if you could remove ADL-S devices in a separate commit.
CB:55221 Ack
https://review.coreboot.org/c/coreboot/+/55205/comment/9498bd56_ae98a4ce PS2, Line 331: device pci 12.5 off end
I'd remove it in the same commit that removes the ADL-S devices (see comment above), and mention why […]
CB:55221 Ack
https://review.coreboot.org/c/coreboot/+/55205/comment/769e433c_51b2909f PS2, Line 334: device pci 13.1 off end
Its for ADL-S
Ack
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/49117629_adf98c19 PS3, Line 372: # W/A to FSP issue
Does this comment still apply?
good point, let me keep those as is, till the time i have verify with latest FSP
File src/mainboard/intel/adlrvp/devicetree_m.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/c1bb0d3d_34b5ea4c PS3, Line 202: device ref pch_espi on end
Already on in chipset. […]
Ack
https://review.coreboot.org/c/coreboot/+/55205/comment/34005b2f_aca466ce PS3, Line 216: device ref fast_spi on end
Already on in chipset. […]
Ack