Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35540 )
Change subject: acpi_table_header: Replace hard-coded length via sizeof(acpi_fadt_t) ......................................................................
Patch Set 5:
(1 comment)
Refer CB:35539 for revision.
https://review.coreboot.org/c/coreboot/+/35540/5/src/mainboard/amd/torpedo/f... File src/mainboard/amd/torpedo/fadt.c:
https://review.coreboot.org/c/coreboot/+/35540/5/src/mainboard/amd/torpedo/f... PS5, Line 53: ACPI_FADT_REV_ACPI_1_0
get_acpi_table_revision(FADT); ?
arch/acpi.h contains multiple macros for FADT Major Revisions as per the ACPI specification. I just changed according to the previous hard-coded values in the files via the specific macros in reference. arch/x86/acpi.c defines the function get_acpi_table_revision which returns ACPI_FADT_REV_ACPI_3_0 for FADT. Should I modify the FADT return case value as per latest ACPI spec(6). What do you suggest?