Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4 ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... PS9, Line 103: child_res->limit &&
Resource allocation for that child would still fail in pass 2 and get reported accordingly. […]
Yes, but shouldn't we skip the whole resource? Pass 2 skips it implicitly, so accounting for its size seems wrong (only matters if we run out of space).
https://review.coreboot.org/c/coreboot/+/41443/9/src/device/resource_allocat... PS9, Line 271: resource->flags |= IORESOURCE_ASSIGNED;
Not clearing IORESOURCE_STORED means we must be called with all non-fixed resources without it set […]
There are potentially resources already stored by blobs. And in some cases, there I'm sure, we have resources stored for console devices. If that's anywhere reported via IORESOURCE_STORED, I don't know. But the old allocator explicitly supported this case.