build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: src/mainboards/asus: Add support for P8Z77-M PRO mainboard ......................................................................
Patch Set 1:
(92 comments)
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... File src/mainboard/asus/p8z77-m_pro/acpi_tables.c:
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 33: get_option ( &usbPoweredS5, "usb_powered_on_s5" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 33: get_option ( &usbPoweredS5, "usb_powered_on_s5" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 33: get_option ( &usbPoweredS5, "usb_powered_on_s5" ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 34: usbPoweredS5 = usbPoweredS5 & 1; /* be sure is 0 or 1 only, not 3,4,5,etc... */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/acpi_... PS1, Line 44: gnvs->tcrt = 95; /* critical temp that will shutdown the pc == 95C degrees */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/mainb... File src/mainboard/asus/p8z77-m_pro/mainboard.c:
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/mainb... PS1, Line 32: install_intel_vga_int15_handler ( GMA_INT15_ACTIVE_LFP_NONE, space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/mainb... PS1, Line 33: GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0 ); line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/mainb... PS1, Line 33: GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0 ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... File src/mainboard/asus/p8z77-m_pro/romstage.c:
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 70: { 0, 2, 3 }, /* USB2 internal header 1 (USB1112 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 71: { 0, 2, 3 }, /* USB2 internal header 1 (USB1112 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 72: { 0, 2, 4 }, /* USB2 internal header 2 (USB910 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 73: { 0, 2, 4 }, /* USB2 internal header 2 (USB910 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 74: { 0, 2, 6 }, /* USB2 internal header 3 (USB78 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 75: { 0, 2, 5 }, /* USB2 internal header 3 (USB78 on board). Let's disable it */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 95: * pnp_set_iobase() funcs write 16bits value ( writes 1st the high part ). line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 98: * The "&0xff" is cuz some systems may define CHAR_SIZE=9, so need a mask. line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 99: * Values are set accoding to the Asus Bios 2203 defaults, extracted using 'accoding' may be misspelled - perhaps 'according'?
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 99: * Values are set accoding to the Asus Bios 2203 defaults, extracted using line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 101: * It's needed to include "#include <drivers/pc80/pc/ps2_controller.asl>" line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 106: pnp_set_logical_device ( KBC_DEV ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 106: pnp_set_logical_device ( KBC_DEV ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 106: pnp_set_logical_device ( KBC_DEV ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 109: pnp_set_iobase(KBC_DEV, 0x60u, 0x0060u); /* KBC1 IO base address (KBD) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 110: pnp_set_iobase(KBC_DEV, 0x62u, 0x0064u); /* KBC2 IO base address (AUX) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 114: /* KB 12Mhz + Disable Port 92 + Gate A20 hw speedup + soft KBRST */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 115: /* Defval=0x83(KBRST by hw instead of sw). Asus Bios 2203 has 0x82 */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 119: * See section "21.10 Configuration Register -> Logical Device A (ACPI)", line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 123: pnp_set_logical_device ( ACPI_DEV ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 123: pnp_set_logical_device ( ACPI_DEV ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 123: pnp_set_logical_device ( ACPI_DEV ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 134: get_option ( &powerOnAfterFail, "power_on_after_fail" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 134: get_option ( &powerOnAfterFail, "power_on_after_fail" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 134: get_option ( &powerOnAfterFail, "power_on_after_fail" ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 135: switch (powerOnAfterFail) { switch and case should be at the same indent
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 156: pnp_write_config ( ACPI_DEV, 0xe4u, acp ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 156: pnp_write_config ( ACPI_DEV, 0xe4u, acp ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 156: pnp_write_config ( ACPI_DEV, 0xe4u, acp ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 162: uint8_t acpiDelay = pnp_read_config ( ACPI_DEV, 0xe7u ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 162: uint8_t acpiDelay = pnp_read_config ( ACPI_DEV, 0xe7u ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 162: uint8_t acpiDelay = pnp_read_config ( ACPI_DEV, 0xe7u ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 163: acpiDelay |= (uint8_t)0x10u; /* Bit 4: Use 0.5s delay, OR mask 10000b=0x10 */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 164: pnp_write_config ( ACPI_DEV, 0xe7u, acpiDelay ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 164: pnp_write_config ( ACPI_DEV, 0xe7u, acpiDelay ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 164: pnp_write_config ( ACPI_DEV, 0xe7u, acpiDelay ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 171: void mainboard_get_spd(spd_raw_data *spd, bool id_only) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 174: read_spd ( &spd[0], 0x50, id_only ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 174: read_spd ( &spd[0], 0x50, id_only ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 174: read_spd ( &spd[0], 0x50, id_only ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 175: read_spd ( &spd[1], 0x51, id_only ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 175: read_spd ( &spd[1], 0x51, id_only ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 175: read_spd ( &spd[1], 0x51, id_only ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 176: read_spd ( &spd[2], 0x52, id_only ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 176: read_spd ( &spd[2], 0x52, id_only ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 176: read_spd ( &spd[2], 0x52, id_only ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 177: read_spd ( &spd[3], 0x53, id_only ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 177: read_spd ( &spd[3], 0x53, id_only ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 177: read_spd ( &spd[3], 0x53, id_only ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 180: int mainboard_should_reset_usb(int s3resume) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 185: void mainboard_fill_pei_data(struct pei_data *pei_data) open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 188: { that open brace { should be on the previous line
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 227: /* copyed mainboard_usb_ports array above and added cable len: line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 228: * {enabled, oc_pin, cable len 0x0080=<8inches/20cm} line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 230: { 1, 0, 0x0080 }, /* USB3 front internal header */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 231: { 1, 0, 0x0080 }, /* USB3 front internal header */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 233: { 1, 1, 0x0080 }, /* USB3 ETH botton connector */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 235: { 1, 2, 0x0080 }, /* USB2 PS2 botton connector */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 236: { 0, 3, 0x0080 }, /* USB2 internal header (USB1112 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 237: { 0, 3, 0x0080 }, /* USB2 internal header (USB1112 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 238: { 0, 4, 0x0080 }, /* USB2 internal header (USB910 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 239: { 0, 4, 0x0080 }, /* USB2 internal header (USB910 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 240: { 0, 6, 0x0080 }, /* USB2 internal header (USB78 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 241: { 0, 5, 0x0080 }, /* USB2 internal header (USB78 on board) */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 248: * 3=Smart Auto(like #2 but keep speed on reboot) line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 251: /* 4 bit switch mask. 0=not switchable, 1=switchable; line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 252: * Means once it's loaded the OS, it can swap ports line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 256: 1, /* 0=No xHCI preOS driver; 1=xHCI preOS driver */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 257: /* 0=Don't use xHCI streams (less speed,more compatibility) line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 258: * 1=use xHCI streams for better speed (and less compatibility) line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 262: /* ASUS P8Z77-M Pro supports 1.35v DIMMs according to the manual */ line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 264: /* PCIe 3.0 support. As we use Ivy Bridge, let's enable this... line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 269: * Better leave it always at Auto for compatibility & stability. line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 282: * 2 = Auto: work as USB2.0(ehci) until OS loads USB3 xhci driver line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 283: * 3 = Smart Auto : same than Auto, but if OS loads USB3 driver and line over 80 characters
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 287: get_option ( &usb3Mode, "usb3_mode" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 287: get_option ( &usb3Mode, "usb3_mode" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 287: get_option ( &usb3Mode, "usb3_mode" ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 292: get_option ( &usb3PreOSDrv, "usb3_preOS_drv" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 292: get_option ( &usb3PreOSDrv, "usb3_preOS_drv" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 292: get_option ( &usb3PreOSDrv, "usb3_preOS_drv" ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 297: get_option ( &usb3Streams, "usb3_streams" ); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 297: get_option ( &usb3Streams, "usb3_streams" ); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33328/1/src/mainboard/asus/p8z77-m_pro/romst... PS1, Line 297: get_option ( &usb3Streams, "usb3_streams" ); space prohibited before that close parenthesis ')'