Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35888 )
Change subject: mb/pcengines/apu2/mainboard.c: create SMBIOS type 16
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/35888/3/src/mainboard/pcengines/apu...
File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35888/3/src/mainboard/pcengines/apu...
PS3, Line 200: switch (spd_buffer[3]) {
that seems complex. […]
At this point CBMEM_ID_MEMINFO is not presented in cbmem, so SPD is good way to read memory information. Indeed, in patch 35889 (SMBIOS type 17 for apu) I fill cbmem with memory info (previously read with SPD), but I wonder if it is not unnecessary duplication since that data is available with SPD.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I590ebf89ecb3f97a9ce028ca34696e5809d66d49
Gerrit-Change-Number: 35888
Gerrit-PatchSet: 3
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Nov 2019 14:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment