This change is ready for review.

View Change

1 comment:

• File src/mainboard/pcengines/apu2/mainboard.c:

  • Patch Set #3, Line 200: switch (spd_buffer[3]) {

    that seems complex. […]

    At this point CBMEM_ID_MEMINFO is not presented in cbmem, so SPD is good way to read memory information. Indeed, in patch 35889 (SMBIOS type 17 for apu) I fill cbmem with memory info (previously read with SPD), but I wonder if it is not unnecessary duplication since that data is available with SPD.

To view, visit change 35888. To unsubscribe, or for help writing mail filters, visit settings.