Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40381 )
Change subject: mb/lenovo/{t420,t420s}: Convert to variant board
......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 2:
Patch Set 2:
Did you check if BUILD_TIMELESS=1 results in identical binaries for these boards?
I would recommend switching to overridetrees in a separate change, as it usually results in changes to the binary. If you carefully align the code before folding the boards into variants, the binaries should be reproducible (as long as you disable the Kconfig option to add the config into the coreboot.rom, if you change Kconfig symbols)
Peter, any updates about this?
Sorry didn't see your comment. Will try it soon.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If117c48cf8e6131b3d25112346d4ddd1ff366009
Gerrit-Change-Number: 40381
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 25 Apr 2020 16:46:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment