Attention is currently required from: Nico Huber, Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38922 )
Change subject: libgfxinit: Allow to configure screen rotation
......................................................................
Patch Set 7:
(2 comments)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/38922/comment/3b64ad46_ece1276b
PS7, Line 500: how the physical screen is mounted in
: 90 degree steps
Positive degrees are counter-clockwise.
In what context? I would absolutely assume the opposite
https://review.coreboot.org/c/coreboot/+/38922/comment/18a5af33_f3ebbd52
PS7, Line 507: Straight
Adjectives, hmmm... There's `unrotated` and `nonrotated`
I'd vote for 'non-rotated.' 'Upright' could be read to imply portrait mode, which would mean a 90* rotation for most monitors
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38922
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac75cefbd34f28c55ec20ee152fe67351cc48653
Gerrit-Change-Number: 38922
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:19:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment