Attention is currently required from: Julius Werner, Jérémy Compostella, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email )
Change subject: vc/google/chromeos: Add low battery indicator screen ......................................................................
Patch Set 4:
(1 comment)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/86225/comment/d918c5ea_79126263?usp... : PS1, Line 128: Don't select if not sure.
Then maybe something like "Enable only if the platform support it" would be more helpful. Should we introduce a `HAVE_` flag to capture this dependency formally?
we cam introduce yet another Kconfig with `HAVE_` but I don't feel there is a need. We can enable these Kconfigs from config.$BOARD in cros build.
But I'm open for the recommendation/suggestion
@jeremy.compostella@intel.com: do you see a need for `HAVE_` Kconfig here? I wish to handle these selection from config.baseboard.brox or similar