[coreboot-gerrit] Change in coreboot[master]: cpu/x86/tsc: Replace TSC_CONSTANT_RATE with UNKNOWN_TSC_RATE

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33928 )

Change subject: cpu/x86/tsc: Replace TSC_CONSTANT_RATE with UNKNOWN_TSC_RATE
......................................................................

Patch Set 14:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33928/14//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33928/14//COMMIT_MSG@7 
PS14, Line 7: cpu/x86/tsc: Replace TSC_CONSTANT_RATE with UNKNOWN_TSC_RATE
I don't understand this subject nor the reason for removing the explicitness of TSC_CONSTANT_RATE. Are you wanting to ensure the default now is semantically equivalent to TSC_CONSTANT_RATE with only the platforms not having that select UNKNOWN_TSC_RATE?

https://review.coreboot.org/c/coreboot/+/33928/14/src/cpu/x86/tsc/delay_tsc.... 
File src/cpu/x86/tsc/delay_tsc.c:

https://review.coreboot.org/c/coreboot/+/33928/14/src/cpu/x86/tsc/delay_tsc.... 
PS14, Line 23: 	(void)tsc_freq_mhz();
Wouldn't we want the caching in one place?