Attention is currently required from: Frank Wu, Tarun Tuli, YH Lin, Subrata Banik, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67920 )
Change subject: mb/google/brya/var/mithrax: adjust I2C5 times for TP
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67920/comment/d6b2d3ad_bea05192
PS3, Line 10: specification
Is it the specification or some datasheet?
It is specification from touch pad vendor.
https://review.coreboot.org/c/coreboot/+/67920/comment/2bdc2e18_d2ad3f71
PS3, Line 11:
Please add the measured values before and after your change.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5977f0dbba8924cc8a1c72c36358d6ba6f2de940
Gerrit-Change-Number: 67920
Gerrit-PatchSet: 4
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ricky Chang
rickytlchang@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Mon, 03 Oct 2022 09:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment