Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 63:
(3 comments)
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 28: ![](p8z77-m_pro.jpg)
Now yes. I just took a photo with my phone.
Great! Thanks!
https://review.coreboot.org/#/c/33328/61/Documentation/mainboard/asus/p8z77-... PS61, Line 34: An external programmer is required
About the period, our whole policy for the text file was not to use periods at the end of the paragr […]
No idea where that policy comes from. In general you add a period if it's a complete sentence. Thus on bullet list items you won't add it.
https://review.coreboot.org/#/c/33328/62/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/62/Documentation/mainboard/asus/p8z77-... PS62, Line 34: An external programmer is required. You can just extract the SPI mentioning programmers or flashrom commands is not helpful. Those should go into https://doc.coreboot.org/flash_tutorial/index.html.
Just mention that you have to flash standalone, as flashing in-circuit doesn't work.