Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 )
Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/19043/5/src/mainboard/siemens/mc_apl1/ptn346... File src/mainboard/siemens/mc_apl1/ptn3460.c:
PS5, Line 54: 1
Shouldn't these 1's be PTN error codes? That's what you have according to y
No, these are not PTN error codes. At this point we have problems to get the data required for the PTN. In a future driver solution this part will disappear. I changed the comment for the moment.
https://review.coreboot.org/#/c/19043/5/src/mainboard/siemens/mc_apl1/ptn346... File src/mainboard/siemens/mc_apl1/ptn3460.h:
Line 19: #include <stdint.h>
You should include stdint.h so this header is not implicitly dependent on s
Done