Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38231 )
Change subject: sb/intel/common: Move SMBUS register layout outside header
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
What's gained with this?
We get rid of one of ~15 header files where SMBUS related declarations. It also forces abstraction and ownership of the register space to this single file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38231
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I841cc3bd636414c59af15d64d3f96b9be158af98
Gerrit-Change-Number: 38231
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jan 2020 17:59:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment