Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44092 )
Change subject: soc/intel/baytrail: Add MRC SMBus workaround ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44092/3/src/soc/intel/baytrail/roms... File src/soc/intel/baytrail/romstage/raminit.c:
https://review.coreboot.org/c/coreboot/+/44092/3/src/soc/intel/baytrail/roms... PS3, Line 163: CONFIG_MRC_BIN_ADDRESS [IGNORE]sidenote: Hmm it should probably be checked in the Makefile.inc that the entry of the elf file in cbfs matches this.
https://review.coreboot.org/c/coreboot/+/44092/3/src/soc/intel/baytrail/roms... PS3, Line 173: spd_buf
See comments on PS1, MRC expects both pointers to be the same (I tested this on Q1900M). […]
Oh this definitely needs a comment. It seems like this MRC binary has some pretty problematic 'bugs/unimplemented features'.