[coreboot-gerrit] Change in coreboot[master]: mb/tiogapass: use common driver to configure GPIO

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39427 )

Change subject: mb/tiogapass: use common driver to configure GPIO
......................................................................

Patch Set 39:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39427/38/src/mainboard/ocp/tiogapas... 
File src/mainboard/ocp/tiogapass/ramstage.c:

https://review.coreboot.org/c/coreboot/+/39427/38/src/mainboard/ocp/tiogapas... 
PS38, Line 20: 	/* configure Lewisburg PCH GPIO pads */
> FSP-M can reconfigure GPIO using default settings. […]

FSP-M can set GPIOs with the upd field. Setting it NULL should make FSP leave the pads alone.
We probably want to move this initialization to bootblock or romstage (anything that is pre FSP-M) because some of FSP-M functionality expects pads to be configured to meaningful values. 
FSP code does not have any safety checks w.r.t existing GPIO config. So, configuring pads before FSP-M is a good idea