build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27015 )
Change subject: {src,util}: Move constant to the right side of comparison ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/#/c/27015/3/util/msrtool/linux.c File util/msrtool/linux.c:
https://review.coreboot.org/#/c/27015/3/util/msrtool/linux.c@71 PS3, Line 71: return ret ==0; spaces required around that '==' (ctx:WxV)
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c File util/msrtool/msrtool.c:
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@128 PS3, Line 128: if ((fin = fopen(streamfn, "r")) == NULL) { do not use assignment in if condition
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@136 PS3, Line 136: if ((fdout = mkstemp(tmpfn)) == -1) { do not use assignment in if condition
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@140 PS3, Line 140: if ((fout = fdopen(fdout, "w")) == NULL) { do not use assignment in if condition
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@145 PS3, Line 145: if ((fout = fopen(streamfn, "w")) == NULL) { do not use assignment in if condition
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@216 PS3, Line 216: else if ((fin = fopen(difffn, "r")) == NULL) { do not use assignment in if condition
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@226 PS3, Line 226: for (len = strlen(m1start) - 1; strchr("\r\n", m1start[len]) != NULL; --len) line over 80 characters
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrutils.c File util/msrtool/msrutils.c:
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrutils.c@325 PS3, Line 325: if (m= NULL) { spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/#/c/27015/3/util/msrtool/msrutils.c@325 PS3, Line 325: if (m= NULL) { do not use assignment in if condition