[coreboot-gerrit] Change in ...coreboot[master]: board/kukui: Support ADC value for NC

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32353 )

Change subject: board/kukui: Support ADC value for NC
......................................................................

Patch Set 6: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32353/6/src/mainboard/google/kukui/boardid.c 
File src/mainboard/google/kukui/boardid.c:

https://review.coreboot.org/#/c/32353/6/src/mainboard/google/kukui/boardid.c... 
PS6, Line 86: 	/* The last level is NC and may be larger than standard tolerance. */
I don't really understand how we get here when the pin is not connected. Wouldn't that make it float (meaning you could have any possible value)? Or do you have it strapped high somewhere?