Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37456 )
Change subject: mb/google/octopus: Create Foob variant ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/gpio.c:
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... PS1, Line 4: 2018
2019 and same for others
Done
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... PS1, Line 42: sku1_default_override_table
Foob is not assigned with any SKU number, so please move the correct content to default_override_tab […]
Done
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... PS1, Line 69: (sku_id == 1) || (sku_id == 6)
please remove sku settings
Done
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... PS1, Line 80: google_chromeec_cbi_get_sku_id(&sku_id); : if (no_touchscreen_sku(sku_id)) { : c = sku1_default_override_table;
please remove sku settings and use default as first version of variant
Done
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... PS1, Line 15: : #include <boardid.h> : #include <ec/google/chromeec/ec.h> : #include <sar.h> : : const char *get_wifi_sar_cbfs_filename(void) : { : const char *filename = NULL; : uint32_t sku_id; : : if (google_chromeec_cbi_get_sku_id(&sku_id)) : return NULL; : : if (sku_id == 5) : filename = "wifi_sar-laser.hex"; : : return filename; : }
Please help to check whether this is necessary for your current hw settings. […]
Done
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... PS1, Line 2:
Please check and confirm all below component will be candidate source for Foob. […]
Done
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/37456/1/src/mainboard/google/octopu... PS1, Line 24: uint32_t sku_id = SKU_UNKNOWN; : struct device *touchscreen_i2c_host; : : touchscreen_i2c_host = pcidev_path_on_root(PCH_DEVFN_I2C7); : : if (touchscreen_i2c_host == NULL) : return; : : /* SKU ID 1, 6 does not have a touchscreen device, hence disable it. */ : google_chromeec_cbi_get_sku_id(&sku_id); : if (no_touchscreen_sku(sku_id)) : touchscreen_i2c_host->enabled = 0;
please remove the sku variant code, and as always, it could be added later after the exact sku id as […]
Done