Hello Felix Singer, build bot (Jenkins), Nico Huber, David Guckian, Patrick Georgi, Martin Roth, Vanessa Eusebio, Angel Pons, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44774
to look at the new patch set (#8).
Change subject: mb: remove duplicated Make code for spd.bin generation ......................................................................
mb: remove duplicated Make code for spd.bin generation
Drop duplicated code for spd.bin generation that is provided globally in lib/Makefile.inc.
For all affected boards it has been verified that the output binary functionally matches the original one. The changed execution order of Make instructions influenced the cbfs file order. Hence, the rom images can't be compared directly.
Thus, the output files of the two timeless abuild runs have been compared. Further, it was verified that the final files in cbfs stay identical, by comparing the extracted cbfs of each board.
The boards (possibly) needing modification could be found with something like this (with false positives, though):
find src/mainboard -name Makefile.inc | \ xargs egrep 'SPD_BIN|SPD_DEPS' | cut -d: -f1 | sort -u
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: Icd3ac0fd6c901228554115c6350d88bb49874587 --- M src/mainboard/bap/ode_e20XX/Kconfig M src/mainboard/bap/ode_e20XX/Makefile.inc R src/mainboard/bap/ode_e20XX/spd/BAP_Q7_1066.spd.hex R src/mainboard/bap/ode_e20XX/spd/BAP_Q7_800.spd.hex M src/mainboard/gizmosphere/gizmo/Kconfig M src/mainboard/gizmosphere/gizmo/Makefile.inc R src/mainboard/gizmosphere/gizmo/spd/Elpida_EDJ2116DEBG.spd.hex M src/mainboard/gizmosphere/gizmo2/Kconfig M src/mainboard/gizmosphere/gizmo2/Makefile.inc R src/mainboard/gizmosphere/gizmo2/spd/Micron_MT41J128M16JT.spd.hex M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/variants/auron_paine/spd/Makefile.inc M src/mainboard/google/auron/variants/auron_yuna/spd/Makefile.inc M src/mainboard/google/auron/variants/gandof/spd/Makefile.inc M src/mainboard/google/auron/variants/lulu/spd/Makefile.inc M src/mainboard/google/auron/variants/samus/spd/Makefile.inc M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/variants/banon/Makefile.inc M src/mainboard/google/cyan/variants/celes/Makefile.inc M src/mainboard/google/cyan/variants/cyan/Makefile.inc M src/mainboard/google/cyan/variants/edgar/Makefile.inc M src/mainboard/google/cyan/variants/kefka/Makefile.inc M src/mainboard/google/cyan/variants/reks/Makefile.inc M src/mainboard/google/cyan/variants/relm/Makefile.inc M src/mainboard/google/cyan/variants/setzer/Makefile.inc M src/mainboard/google/cyan/variants/terra/Makefile.inc M src/mainboard/google/cyan/variants/ultima/Makefile.inc M src/mainboard/google/cyan/variants/wizpig/Makefile.inc M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/spd/Makefile.inc M src/mainboard/google/drallion/Kconfig M src/mainboard/google/drallion/spd/Makefile.inc M src/mainboard/google/eve/Kconfig M src/mainboard/google/eve/spd/Makefile.inc M src/mainboard/google/glados/Kconfig M src/mainboard/google/glados/variants/asuka/Makefile.inc M src/mainboard/google/glados/variants/caroline/Makefile.inc M src/mainboard/google/glados/variants/cave/Makefile.inc M src/mainboard/google/glados/variants/chell/Makefile.inc M src/mainboard/google/glados/variants/glados/Makefile.inc M src/mainboard/google/glados/variants/lars/Makefile.inc M src/mainboard/google/glados/variants/sentry/Makefile.inc M src/mainboard/google/hatch/Kconfig D src/mainboard/google/hatch/spd/Makefile.inc M src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc M src/mainboard/google/kahlee/variants/careena/spd/Makefile.inc M src/mainboard/google/kahlee/variants/nuwani/spd/Makefile.inc M src/mainboard/google/kahlee/variants/treeya/spd/Makefile.inc M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/spd/Makefile.inc M src/mainboard/google/rambi/Kconfig M src/mainboard/google/rambi/variants/banjo/Makefile.inc M src/mainboard/google/rambi/variants/candy/Makefile.inc M src/mainboard/google/rambi/variants/clapper/Makefile.inc M src/mainboard/google/rambi/variants/enguarde/Makefile.inc M src/mainboard/google/rambi/variants/glimmer/Makefile.inc M src/mainboard/google/rambi/variants/gnawty/Makefile.inc M src/mainboard/google/rambi/variants/heli/Makefile.inc M src/mainboard/google/rambi/variants/kip/Makefile.inc M src/mainboard/google/rambi/variants/ninja/Makefile.inc M src/mainboard/google/rambi/variants/orco/Makefile.inc M src/mainboard/google/rambi/variants/quawks/Makefile.inc M src/mainboard/google/rambi/variants/rambi/Makefile.inc M src/mainboard/google/rambi/variants/squawks/Makefile.inc M src/mainboard/google/rambi/variants/sumo/Makefile.inc M src/mainboard/google/rambi/variants/swanky/Makefile.inc M src/mainboard/google/rambi/variants/winky/Makefile.inc M src/mainboard/google/slippy/Kconfig M src/mainboard/google/slippy/variants/falco/Makefile.inc M src/mainboard/google/slippy/variants/leon/Makefile.inc M src/mainboard/google/slippy/variants/peppy/Makefile.inc M src/mainboard/google/slippy/variants/wolf/Makefile.inc M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/spd/Makefile.inc M src/mainboard/intel/cannonlake_rvp/spd/Makefile.inc M src/mainboard/intel/harcuvar/Kconfig M src/mainboard/intel/harcuvar/spd/Makefile.inc M src/mainboard/intel/icelake_rvp/spd/Makefile.inc M src/mainboard/intel/jasperlake_rvp/spd/Makefile.inc M src/mainboard/intel/kblrvp/spd/Makefile.inc M src/mainboard/intel/kunimitsu/Kconfig M src/mainboard/intel/kunimitsu/spd/Makefile.inc M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/spd/Makefile.inc M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t430s/variants/t431s/spd/Makefile.inc M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc R src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.spd.hex R src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.spd.hex R src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.spd.hex M src/mainboard/razer/blade_stealth_kbl/spd/Makefile.inc M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/lumpy/Makefile.inc D src/mainboard/samsung/lumpy/spd.hex A src/mainboard/samsung/lumpy/spd/lumpy.spd.hex 96 files changed, 133 insertions(+), 1,029 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44774/8