Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40116 )
Change subject: mb/tglrvp: Configure intel common config
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40116/2/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40116/2/src/mainboard/intel/tglrvp/...
PS2, Line 131:
tabify indentation.
Done
https://review.coreboot.org/c/coreboot/+/40116/2/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40116/2/src/mainboard/intel/tglrvp/...
PS2, Line 124: .i2c[0] = {
: .speed = I2C_SPEED_FAST,
are you missing a level of indentation in these sections?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7a1e9bd94ff86faa390b5de0518e8b3cb668bff
Gerrit-Change-Number: 40116
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Apr 2020 20:42:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment