[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48286/3/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/48286/3/src/soc/intel/common/block/... 
PS3, Line 442: mov	%edi, %ecx /* Restore number of ways */
This will have to be outside the #if because ecx is expected to have number of ways in the end. BTW, please see Tim's comment on previous patchset about using edx instead of ecx. That way you don't need to backup/restore to ecx.