8 May
2020
8 May
'20
2:02 p.m.
Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41046 )
Change subject: tests: Add region-test for rdev API ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41046/3/tests/commonlib/region-test... File tests/commonlib/region-test.c:
https://review.coreboot.org/c/coreboot/+/41046/3/tests/commonlib/region-test... PS3, Line 119: will_return_maybe(mock_mmap, mmap_result);
Could probably check the return value of the call and just fall back to -lcmocka without any extra t […]
Hmm.. yes, this may be the best option. At least this will improve situation for setups with pkg-config installed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/41046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4932402f54768557e5b22b16e66220bd90ddebfd
Gerrit-Change-Number: 41046
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Jan Dabros
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 08 May 2020 20:02:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Jan Dabros
Gerrit-MessageType: comment