[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/sandybridge: Reserve CAR region with !NATIVE_RAMINIT

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31150 )

Change subject: nb/intel/sandybridge: Reserve CAR region with !NATIVE_RAMINIT
......................................................................

Patch Set 3:

(1 comment)

Matt, can you experiment/extend this to the platforms you need to use MRC blob with?
I am hoping to see they would have their pool at a better location.

https://review.coreboot.org/#/c/31150/2/src/northbridge/intel/sandybridge/ra... 
File src/northbridge/intel/sandybridge/raminit_mrc.c:

https://review.coreboot.org/#/c/31150/2/src/northbridge/intel/sandybridge/ra... 
PS2, Line 301: BIOS_DEBUG
> Should that be an error or warning?

Good question. If we were able to parse (MRC internal structure) and the used pool did not end up where linker script had its reserve, I might even add die() above...