Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40677 )
Change subject: soc/amd/{common,picasso}: Move GFX device from static ASL to SSDT ......................................................................
Patch Set 7:
Patch Set 6:
I like the acpi_device_write_pci_dev() idea and all. But so far this graphics.c doesn't seem to be vendor/chip specific. Is there more to come? Shouldn't we extend `default_pci_ops_dev` instead?
Yes, there is more to come. Still working on a series of patches. And this is not something that will be used only by graphics device. I will need another couple of days to push rest of my patches.
Well, I meant more for the `graphics.c` because so far it's not chip specific. Just boilerplate that could also live in common code.
Not all platforms would want to have acpi_device_write_pci_dev() done by default for graphics device. Also, at that point, it is not just about graphics device. PCI devices handled by default_pci_ops_dev are currently added statically to DSDT on most platforms. There will have to be a bigger clean up if we want to extend default_pci_ops_dev.