Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43011 )
Change subject: mb/google/zork: adjust eSPI virtual irq settings
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43011/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43011/1//COMMIT_MSG@13
PS1, Line 13: ACPI for P2/S devices are active edge high
I'm pretty sure the kernel ignores the ACPI entries. […]
That's up to the kernel. By removing SIO_EC_PS2K_IRQ then the advertised IRQ resource is active edge high.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia28d82cd9e432df98839f68bac4eae4447455e53
Gerrit-Change-Number: 43011
Gerrit-PatchSet: 1
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jul 2020 19:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment