Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41992 )
Change subject: [WIP] sb/intel: Always raise SMI with APM_CNT_FINALIZE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41992/2/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41992/2/src/southbridge/intel/bd82x... PS2, Line 214: return;
Sorry, wrong words. It's impossible for the payload to trigger execution […]
Ahh.. I did not realize payload has to do this via SMI. I still think it is wrong that raising APM_CNT_FINALIZE is not consistent across platforms. But it would only be an issue if we needed mainboard_smi_apmc() do something at finalize.