Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31917 )
Change subject: soc/intel/cnl: Generate DMAR ACPI table ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/#/c/31917/14/src/soc/intel/cannonlake/acpi.c File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/#/c/31917/14/src/soc/intel/cannonlake/acpi.c@314 PS14, Line 314: struct device *const ipu_dev = dev_find_slot(0, SA_DEVFN_IPU); : uint64_t ipuvtbar = MCHBAR64(IPUVTBAR) & VTBAR_MASK; : bool ipuvten = MCHBAR32(IPUVTBAR) & VTBAR_ENABLED; : : if (ipu_dev && ipu_dev->enabled && ipuvtbar && ipuvten) { : unsigned long tmp = current; : : current += acpi_create_dmar_drhd(current, 0, 0, ipuvtbar); : current += acpi_create_dmar_ds_pci(current, 0, 5, 0); : : acpi_dmar_drhd_fixup(tmp, current); : } Does this even exist for CFL or CML?
https://review.coreboot.org/#/c/31917/14/src/soc/intel/cannonlake/include/so... File src/soc/intel/cannonlake/include/soc/systemagent.h:
https://review.coreboot.org/#/c/31917/14/src/soc/intel/cannonlake/include/so... PS14, Line 42: #define VTBAR_ENABLED 0x01 : #define VTBAR_MASK 0x7ffffff000ull These should be placed under GFXVTBAR as they are fields within that register.