Christian Gmeiner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31499
Change subject: soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..) ......................................................................
soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..)
fast_spi_get_bios_region(..) returns the size of the BIOS region as defined in the IFD. It is wrong the substract 256k from that size and use the resulting value to call xlate_region_device_ro_init(..).
The result is that the region used by the newly created region_device is 256K smaller then the one defined in IFD.
Change-Id: Ic950f28990a645556a04303f04953a7bc5e41a39 Signed-off-by: Christian Gmeiner christian.gmeiner@gmail.com --- M src/soc/intel/apollolake/mmap_boot.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/31499/1
diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c index 1c3077e..6b05752 100644 --- a/src/soc/intel/apollolake/mmap_boot.c +++ b/src/soc/intel/apollolake/mmap_boot.c @@ -92,8 +92,7 @@ bios_mapped_size);
xlate_region_device_ro_init(real_dev_ptr, &shadow_dev_ptr->rdev, - start, bios_mapped_size, - CONFIG_ROM_SIZE); + start, size, CONFIG_ROM_SIZE);
car_set_var(bios_size, size); }