Attention is currently required from: Paul Menzel, Angel Pons, Iru Cai.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46630 )
Change subject: mb/hp: Add EliteBook 820 G2
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/hp/elitebook_820_g2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46630/comment/0993ce64_6469a9a0
PS10, Line 2: register "gfx" = "GMA_STATIC_DISPLAYS(0)"
: register "gpu_dp_b_hotplug" = "4"
: register "gpu_dp_c_hotplug" = "4"
: register "gpu_dp_d_hotplug" = "0"
: register "panel_cfg" = "{
: .up_delay_ms = 200,
: .down_delay_ms = 50,
: .cycle_delay_ms = 500,
: .backlight_on_delay_ms = 1,
: .backlight_off_delay_ms = 1,
: .backlight_pwm_hz = 200,
: }"
I missed this somehow. Please move into the graphics controller.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8b3b7f735460c5e76a2dc9ab2d10154e6606ad6
Gerrit-Change-Number: 46630
Gerrit-PatchSet: 10
Gerrit-Owner: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Mon, 22 May 2023 04:51:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment