[coreboot-gerrit] Change in coreboot[master]: drivers/pcie/rtd3/device: Add PCIe RTD3 driver

[Raul Rangel (Code Review)]

Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Paul Menzel, Tim Wawrzynczak, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54966 )

Change subject: drivers/pcie/rtd3/device: Add PCIe RTD3 driver
......................................................................

Patch Set 4:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/54966/comment/2758718b_65e9881b 
PS1, Line 9:  I decided
           : to copy and modify it because the Intel driver has a lot of Intel
           : specific code.
> Thanks Raul!

Done

File src/soc/amd/common/block/rtd3/rtd3.c:

https://review.coreboot.org/c/coreboot/+/54966/comment/b277f36f_a2f8b515 
PS1, Line 109: Name (_PR2, Package (0x01)  // _PR2: Power Resources for D2
             :  *            {
             :  *                RTD3
             :  *            })
> Please also mention this difference in the commit message.

Removed _PR2, so no longer relevant.

https://review.coreboot.org/c/coreboot/+/54966/comment/448e7dcd_55b157f3 
PS1, Line 206: PXSX
> Thanks Raul!

Looks like the upstream patch has been tested on the original hardware. I'll get that pulled into our tree.

https://review.coreboot.org/c/coreboot/+/54966/comment/e655a741_0d83a252 
PS1, Line 210: pci_dev_read_resources
No worries, glad we hashed it out. At least we know why we are doing it this way now :)

So is the driver good as is then?
> Probably make a note that the driver does not handle any downstream graphics devices?

Should I just call pci_rom_ssdt from the rtd3 ssdt method?

https://review.coreboot.org/c/coreboot/+/54966/comment/8bb9366d_2c8c5ce4 
PS1, Line 221: drivers_nvme_generic_config
> Is it soc_amd_common_block_rtd3_config?

Done