Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37263 )
Change subject: mb/google: Add ALIGNED flag to known sections that need alignment ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... File src/mainboard/google/auron/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 7: RW_SECTION_A@0x0 0xf0000 {
Please also add this for all RW_SECTION_(A/B).
RW_SECTION_A/B are updated by flashrom, so actually it does not need alignment.
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 20: SHARED_DATA@0x0 0x2000
...and for both of these...
Why do we need these to be aligned? I don't see anywhere firmware is trying to update these data (only read)
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 23: RW_VPD(PRESERVE)@0x1f8000 0x2000
...and for all RW_VPD...
RW_VPD is handled by flashrom so we don't need it
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 25: SMMSTORE(PRESERVE)@0x200000 0x40000
... […]
Done
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 26: RW_LEGACY(CBFS)@0x240000 0x1c0000
...and probably for RW_LEGACY too.
RW_LEGACY is updated by flashrom so we don't need it