Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46480 )
Change subject: vc/intel/FSP2_0/CPX-SP: add FSPM DIMM watermark option ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46480/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/46480/1/src/vendorcode/intel/fsp/fs... PS1, Line 498: #if CONFIG_HAVE_FSPM_DIMM_WATERMARK_OPTION : /** Offset 0x00C4 - Usage type for Memory Refresh Watermark : Select Memory Refresh Watermark, 0: Auto (default), 1: High, 2: Low : **/ : UINT8 MemRefreshWaterMark; : #endif
Any reason to put this here and not in one of the UnusedUpdSpace areas where you would get around ne […]
Intel groups configurations together (this is a good practice), and hence this option belongs to Memory Pre-Mem group. Good idea to use UnusedUpdSpace. There are several ones scattered. I will use the top most one (and sacrifice the grouping), so that I do not have to rebase the patch too often. I will mark this patch and [CB: 46609] as private as they are used by the team. I will create another patch instead.