22 Oct
2019
22 Oct
'19
9:25 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35990 )
Change subject: cpu/intel/car: Correctly cache the bootblock with C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35990/3/src/cpu/intel/car/core2/cac... File src/cpu/intel/car/core2/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/35990/3/src/cpu/intel/car/core2/cac... PS3, Line 28: #endif
Move to `mtrr.h`?
I actually don't think it is such a good idea. This limitation does not hold on CPU's that have a non-eviction mode and there is no Kconfig symbol for that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8104ca9c51e4d2eccdb277e4c2111d2da662f3e
Gerrit-Change-Number: 35990
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 22 Oct 2019 19:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment