Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43336 )
Change subject: soc/intel/xeon_sp/cpx: display SystemMemoryMapHob fields
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43336/4/src/soc/intel/xeon_sp/cpx/h...
File src/soc/intel/xeon_sp/cpx/hob_display.c:
https://review.coreboot.org/c/coreboot/+/43336/4/src/soc/intel/xeon_sp/cpx/h...
PS4, Line 188: soc_display_memmap_hob((const struct SystemMemoryMapHob **)(guid + 16));
We had thought what is stored in the HOB structure (following 16 bytes of GUID) is the HOB data. […]
Ah, I see. Thanks for the clarification.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I271bcbd6030276b8fcd99d5b4f2c93f034dd9b52
Gerrit-Change-Number: 43336
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Nate DeSimone
nateman1352@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Jul 2020 10:22:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment