Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47308 )
Change subject: mb/google/zork: Init fingerprint GPIOs for boot vs resume ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47308/6/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47308/6/src/mainboard/google/zork/v... PS6, Line 304: if (google_chromeec_cbi_get_board_version(&board_version)) : board_version = 1; : This reads board version but doesn't do anything with it. Not sure if you were intending to add check for board version here.